data (rd3): fix import and data model issues #4568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This PR addresses the issues listed in molgenis/projects-solve-rd#60 |
davidruvolo51
changed the title
davidruvolo51
commented
Dec 17, 2024
| @@ -32,6 +33,7 @@ public void run() { | |||
| } | |||
| List<Row> rows = getProfilesFromAllModels("/portal", List.of()); | |||
| getSchema().migrate(Emx2.fromRowList(rows)); | |||
| MolgenisIO.fromClasspathDirectory("/_ontologies", getSchema(), false); | |||
There was a problem hiding this comment.
I'm not sure if this is the correct approach for the profiles and other data models. I used the other loaders as a guide.
mswertz
approved these changes
Dec 20, 2024
| @@ -32,6 +33,7 @@ public void run() { | |||
| } | |||
| List<Row> rows = getProfilesFromAllModels("/portal", List.of()); | |||
| getSchema().migrate(Emx2.fromRowList(rows)); | |||
| MolgenisIO.fromClasspathDirectory("/_ontologies", getSchema(), false); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This list is evolving)
What are the main changes you did:
The purpose of this PR is to resolve all importing issues and data model changes to the RD3_v2 model
Organisations: changed all instances toref/ref_array; added generic resource to resolve import errorsconsent document typeimport failureassigned gender at birthcsvHow to test
Checklist