Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use semantic name for constants #4589

Merged
merged 2 commits into from
Jan 6, 2025
Merged

chore: use semantic name for constants #4589

merged 2 commits into from
Jan 6, 2025

Conversation

esthervanenckevort
Copy link
Member

What are the main changes you did

  • Renamed constants to have a semantic name, which though longer, would make it easier to find.

How to test

  • If it compiles it is otherwise equal to the current main branch, so no additional tests are needed

Checklist

None of these tasks were relevant:

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

@esthervanenckevort
chore: use semantic name for the constant setting the max execution time
8b7260c
@esthervanenckevort
fixed Migrations.java
32c60a2 
- Updated reference to TEN_SECONDS to MAX_EXECUTION_TIME_IN_SECONDS
- Refactored THREE_MINUTES to a semantic name
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@esthervanenckevort esthervanenckevort merged commit 41510aa into master Jan 6, 2025
7 checks passed
@esthervanenckevort esthervanenckevort deleted the chore/use-semantic-name-for-constants branch January 6, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connoratrug connoratrug connoratrug approved these changes

@mswertz mswertz Awaiting requested review from mswertz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@esthervanenckevort @connoratrug