Skip to content

fix: ref modal with external schema #5041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 12, 2025
Merged

fix: ref modal with external schema #5041

merged 1 commit into from
May 12, 2025

Conversation

chinook25
Copy link
Contributor

What are the main changes you did

How to test

  • explain here what to do to test this (or point to unit tests)

Checklist

  • updated docs in case of new feature
  • added/updated tests
  • added/updated testplan to include a test for this fix, including ref to bug using # notation

chinook25
chinook25 commented May 12, 2025
View reviewed changes
apps/dev-proxy.config.js
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to this file is because someone forgot to format it :/

mswertz
mswertz reviewed May 12, 2025
View reviewed changes
Copy link
Member

@mswertz mswertz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Lets await functional validation

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

dtroelofsprins
dtroelofsprins approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@dtroelofsprins dtroelofsprins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review:

  • It's now possible (again) to open the details from an ontology/ref to a table in another schema in the table explorer again
  • Links to tables in the same schema still work
  • Using the data form to add new records still works fine

@chinook25 chinook25 merged commit 8cdb1a3 into master May 12, 2025
6 of 7 checks passed
@chinook25 chinook25 deleted the fix/external-schema-ref-modal branch May 12, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mswertz mswertz mswertz left review comments

@dtroelofsprins dtroelofsprins dtroelofsprins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(table-explorer): clicking on a value in a reference column gets stuck when the refTable is in another schema
3 participants
@chinook25 @mswertz @dtroelofsprins