Swap Illuminate EventServiceProvider in favour of plain ServiceProvider #248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #247
Explanation
According to the issue ticket, extending the Illuminate
EventServiceProvider
may cause listeners to get registered twice somehow. I haven't verified this, butFix
This patch swaps out the
EventServiceProvider
and adopts the plainServiceProvider
, so all the core event stuff doesn't accidentally gets mixed in.