feat(gateway): support external web UI assets for distro and docker builds#167
Open
feat(gateway): support external web UI assets for distro and docker builds#167
Conversation
Contributor
Merging this PR will not alter performance
Comparing Footnotes
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web-ui(routes/templates) andweb-ui-embedded-assets(static embedding).MOLTIS_ASSETS_DIR-> compiledMOLTIS_DEFAULT_ASSETS_DIR-> dev source path -> embedded fallback./usr/share/moltis/assets.docs/src/web-ui-assets.md, Docker/index links) and changelog entries.Validation
Completed
taplo fmtjust formatcargo test -p moltis-gateway sanitize_asset_path -- --nocapturecargo check -p moltiscargo check -p moltis --no-default-features --features "file-watcher,local-llm,metrics,prometheus,push-notifications,qmd,tailscale,tls,voice,web-ui"cargo check -p moltis --no-default-features --features "file-watcher,tailscale,tls,web-ui,web-ui-embedded-assets"cargo +nightly-2025-11-30 clippy -Z unstable-options --workspace --all-targets --timings -- -D warningsRemaining
cargo +nightly-2025-11-30 clippy -Z unstable-options --workspace --all-features --all-targets --timings -- -D warningsReason: this environment does not have CUDA (
nvcc) available;--all-featurespulls CUDA build paths. Used the documented macOS fallback clippy invocation above.Manual QA
MOLTIS_ASSETS_DIRto a valid assets directory and verify/and/assets/style.cssload./usr/share/moltis/assetsand UI loads at/.MOLTIS_ASSETS_DIRand UI loads.