feat(skills): gate installer behind install feature#187
Open
M09Ic wants to merge 1 commit intomoltis-org:mainfrom
Open
feat(skills): gate installer behind install feature#187M09Ic wants to merge 1 commit intomoltis-org:mainfrom
M09Ic wants to merge 1 commit intomoltis-org:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background / Motivation
We are targeting a minimal moltis agent build for edge-device environments. The HTTP/TLS stack pulled by
reqwesthas a significant binary-size impact, so installer-related networking should be feature-gated and only enabled when needed.In our local minimal-path validation (
cerebellumrelease), binary size dropped from 8,167,936 bytes to 5,128,192 bytes (-37.22%). This PR is the first foundational step: make the skills installer an explicit feature.Changes
crates/skills/Cargo.tomlreqwestoptional.install = ["dep:reqwest"].default = ["install"]to preserve existing behavior.crates/skills/src/lib.rsinstallmodule behind#[cfg(feature = "install")].Compatibility
Validation
cargo check -p moltis-skillscargo check -p moltis-skills --no-default-featurescargo check -p moltis-skills --no-default-features --features install