fix(csp): eliminate inline scripts to fix Safari CSP violations#95
Open
fix(csp): eliminate inline scripts to fix Safari CSP violations#95
Conversation
Move executable inline scripts to external files or non-executable
types. Only the import map remains inline with a CSP nonce.
- Extract theme-init IIFE to external js/theme-init.js
- Convert gon data from window.__MOLTIS__ assignment to
type="application/json" blob parsed by gon.js
- Remove inline favicon and title-update scripts (already handled
by app.js applyIdentity / applyIdentityFavicon)
- Remove nonce from external module scripts (allowed by 'self')
- Add applyIdentityFavicon to login-app.js
- Add theme-init.js to service worker cache
CSP policy unchanged: script-src 'self' 'nonce-{uuid}'
Contributor
Merging this PR will not alter performance
Comparing Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<script>tags to external files or non-executable typesscript-src 'self' 'nonce-{uuid}'— nounsafe-inlineaddedChanges
js/theme-init.js(no nonce, allowed by'self')window.__MOLTIS__ = {...}<script type="application/json" id="__MOLTIS_GON__">(non-executable, no CSP check)app.js→applyIdentityFavicon())app.js→applyIdentity())app.jsmodule (external)'self')Applied same pattern to
login.htmlandonboarding.html.Validation
Completed
cargo test— all 345 gateway tests pass, full suite greenjust format-check— cleancargo clippy -p moltis-gateway -- -D warnings— cleanbiome check --write— JS files formattedRemaining
npx playwright test)Manual QA
Pending — requires running the gateway and checking Safari Web Inspector for CSP violation logs.