Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ghost-solid-button): add styling #420

Conversation

nataliadelmar
Copy link
Collaborator

@nataliadelmar nataliadelmar commented Jul 27, 2023

Description

Although not speficied in Momentum Figma Library, there are some cases in which we need a ghost button that has a solid color without an outline: that is, a background that looks same color as theme background black/white, but it is not transparent and has no outline.

Like this but without the border/outline:
image

That is, a button with these properties:

  • ghost = true and solid = true. If it would be ghost=false and solid=true, that should result in the primary button which has a solid color. If it would be ghost=true and solid=false, that would result in a button with a transparent background.
  • outline = false

That makes this button, for example, work correctly because we need solid buttons with ghost backgrounds.
image

Links

Links to relevent resources.

@nataliadelmar nataliadelmar added the validated If the pull request is validated automation. label Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validated If the pull request is validated automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant