Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TabList): require aria-label (or equivalent) #690

Conversation

dominiccarrington
Copy link
Collaborator

@dominiccarrington dominiccarrington commented Nov 4, 2024

Description

Introduce a AriaLabelRequired type and require aria-label (or equivalent) for TabList

Links

If the tab list has a visible label, the element with role tablist has aria-labelledby set to a value that refers to the labelling element. Otherwise, the tablist element has a label provided by aria-label.
https://www.w3.org/WAI/ARIA/apg/patterns/tabs/

@dominiccarrington dominiccarrington added the validated If the pull request is validated automation. label Nov 4, 2024
@dominiccarrington dominiccarrington changed the title fix(TabList): require aria-label (or equalivent) fix(TabList): require aria-label (or equivalent) Nov 4, 2024
@dominiccarrington dominiccarrington marked this pull request as ready for review November 4, 2024 18:10
src/utils/a11y.ts Outdated Show resolved Hide resolved
@dominiccarrington dominiccarrington merged commit 2706875 into momentum-design:master Nov 7, 2024
5 checks passed
Copy link

github-actions bot commented Nov 7, 2024

🎉 This PR is included in version 26.174.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released validated If the pull request is validated automation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants