Static map list headers #1064
Merged
Static map list headers #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsa96
force-pushed
the
feat/map-list-headers
branch
from
715b4a8
to
ca7bd1b
Compare
tsa96
force-pushed
the
feat/map-list-headers
branch
2 times, most recently
from
1eeb6c8
to
e588fe1
Compare
Panzerhandschuh
approved these changes
Oct 23, 2024
Panzerhandschuh
approved these changes
Nov 12, 2024
This causes a DB error, was happening when trying to add thousands of maps at once
Evil indentation commit, just wrapping a jest block
Used to do these weird exported objects which is pointless with ESM, figured I'd clean this up. Also, wasn't actually using `isEqual`...
Makes C++ angry
Backend side of this was done, forgot to update frontend.
tsa96
force-pushed
the
feat/map-list-headers
branch
from
3ffc8ea
to
4760562
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a simple header block to static map lists storing
Makes C++ allocs faster and simpler.
Checks
nx run db:create-migration <name>and committed the migration if I've made DB schema changesfeat: Add foo,chore: Update bar, etc...fixuped into my original commits