Open
Conversation
mijovic
commented
Oct 4, 2025
|
|
||
| uint256 private constant REVERT_REASON_MAX_LEN = 2048; | ||
| uint256 private constant PENALTY_PERCENT = 10; | ||
| uint256 private constant PENALTY_PERCENT = 100; |
Collaborator
Author
There was a problem hiding this comment.
This is the only change required to charge gas full limit specified in userOp
1304944 to
3f88c50
Compare
|
noting that removal of https://github.com/eth-infinitism/account-abstraction/blob/cc3893bcaf2272c163ce89d5eb9eadb8e6b52db7/contracts/core/EntryPoint.sol#L47 would be relevant for this but likely occurred in a different PR . with no refunds this threshold should be zero. i wanted to justify bumping this due higher costs for several operations. However no cold loads should happen and the operations being performed here dont seem to have different gas costs associated with them so 10k seems fine |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR: