Closed
Conversation
mijovic
commented
Oct 20, 2025
|
|
||
| SenderCreator private immutable _senderCreator = new SenderCreator(); | ||
|
|
||
| ISscOpcodes private immutable _ssc = ISscOpcodes(address(0x665e930982A9a03c844641d453a2C3462ED7Ff41)); |
Collaborator
Author
There was a problem hiding this comment.
Deploying bytecode 0x60a2600b5f3960a25ff3fe600734156097565b600d6070565b63e7837508811460435763346527bf8114604c57638315b35381146055576386c3ee6e8114605e5763b7987bb481146067575f5ffd5bd0805f5260205ff35bd1805f5260205ff35bd2805f5260205ff35bd3805f5260205ff35bd4805f5260205ff35b5f7c01000000000000000000000000000000000000000000000000000000005f3504905090565b80609f575f5ffd5b5056 with salt 0x769a9f24a3e8cd02f97cdc25df023d91b7440615a2e6126d91057f41b87cb7b2 using CreateX.deployCreate2
mijovic
commented
Oct 20, 2025
Comment on lines
+32
to
+38
| int256 constant public SSC_STORAGE_SLOT_COST = 12800000000000000; | ||
| int256 constant public SSC_STORAGE_SLOT_REFUND = 12672000000000000; | ||
|
|
||
| int256 constant public SSC_ACCOUNT_COST = 12800000000000000; | ||
| int256 constant public SSC_ACCOUNT_REFUND = 12672000000000000; | ||
|
|
||
| int256 constant public SSC_CODE_CREATED_COST = 12800000000000000; |
Collaborator
Author
There was a problem hiding this comment.
Have to set correct values
mijovic
force-pushed
the
v0.7-monad-ssc-option1
branch
from
4ffc61d to
a946b64
Compare
mijovic
force-pushed
the
v0.7-monad-ssc-option1
branch
from
a946b64 to
5628e7f
Compare
mijovic
commented
Oct 22, 2025
| // this can be negative in cases of refunds | ||
| int256 netSSC = _netSSC() - preSSC; | ||
| // In case of negative netSSC msg.value must be higher than abs(netSSC) | ||
| uint256 sscCompensation = uint256(int256(msg.value) + netSSC); |
Collaborator
Author
There was a problem hiding this comment.
The conversion would revert the whole bundle here in case of msg.value is smaller than the refund
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.