Open
Conversation
keone
approved these changes
Mar 4, 2025
portdeveloper
requested changes
Mar 5, 2025
Member
There was a problem hiding this comment.
Just one small nitpick here:
The deployedContracts.ts file under packages/nextjs/contracts is regenerated on deployments and we should probably keep it as it is in a clean SE-2. The file is used to keep a tie between the deployed contracts and the frontend and will be different for every contract.
Below is what this template should have:
`/**
- This file is autogenerated by Scaffold-ETH.
- You should not edit it manually or your changes might be overwritten.
*/
import { GenericContractsDeclaration } from "~~/utils/scaffold-eth/contract";
const deployedContracts = {} as const;
export default deployedContracts satisfies GenericContractsDeclaration;
`
Scaffold-ETH 2 will auto-modify it when people deploy contracts.
P.S.: I have a monad extension PR coming for scaffold-eth so it will be a lot easier for people to get started with SE-2. We might not even need this repo!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
monadDevnet->monadTestnet