Update chain ID#3
Closed
zkharit wants to merge 2 commits intomonad-developers:mainfrom
zkharit:zane/update-chain-id
Closed
Update chain ID#3zkharit wants to merge 2 commits intomonad-developers:mainfrom zkharit:zane/update-chain-id
zkharit wants to merge 2 commits intomonad-developers:mainfrom
zkharit:zane/update-chain-id
Conversation
Author
|
@therealharpaljadeja quick PR updating to the new chain ID |
therealharpaljadeja
approved these changes
Jan 27, 2025
Member
therealharpaljadeja
left a comment
therealharpaljadeja
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Author
|
Youre welcome! Is there something I need to do to fix the lint CI job? It seems like there is a test that is trying to deploy a contract, but there is no private key within the jobs env vars thats able to complete that step |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update example to use new correct chain ID. The example, as currently written, has issues with mismatching networks. This PR fixes those issues
Additional Information
Related Issues
Closes #{issue number}
Note: If your changes are small and straightforward, you may skip the creation of an issue beforehand and remove this section. However, for medium-to-large changes, it is recommended to have an open issue for discussion and approval prior to submitting a pull request.
Your ENS/address: