Skip to content

Add Data Nexus testnet validator metadata (ID: 214)#832

Merged
johnmarcou merged 1 commit intomonad-developers:mainfrom
datanexus-vincent:main
Feb 17, 2026
Merged

Add Data Nexus testnet validator metadata (ID: 214)#832
johnmarcou merged 1 commit intomonad-developers:mainfrom
datanexus-vincent:main

Conversation

@datanexus-vincent
Copy link
Contributor

Added JSON file for Data Nexus' testnet validator metadata

@greptile-apps
Copy link

greptile-apps bot commented Feb 17, 2026

Greptile Summary

This PR adds a new testnet validator metadata JSON file for Data Nexus (validator ID 214), following the established pattern for this repository.

Changes:

  • Adds testnet/0214d264e81e38cc0e75a86e663b0ea33fd2d5772443a889018860660ddaea8494.json with all 8 required fields (id, name, secp, bls, website, description, logo, x)
  • Filename correctly matches the secp public key value
  • BLS key is 96 hex characters, consistent with BLS12-381 G1 compressed point format and matches all other validators in the repository
  • JSON structure and field types match the example schema exactly
  • Logo URL uses HTTPS and points to a favicons/android-icon-192x192.png path — a favicon rather than a dedicated validator logo, which may render poorly in UI contexts expecting larger images, but is not a hard schema violation
  • The critical on-chain key verification (secp/bls matching the staking contract at ID 214) will be confirmed by the CI validation workflow (scripts/validate.py)

Confidence Score: 4/5

  • This PR is safe to merge pending CI confirmation that the secp/bls keys match on-chain data for validator ID 214.
  • The JSON file is well-formed, contains all required fields with correct types, the filename correctly matches the secp key, and the BLS key follows the expected 96-character hex format consistent with every other validator in the repository. The only non-critical finding is that the logo URL points to a favicon asset. The CI workflow (scripts/validate.py) will perform the definitive on-chain key match check, which is the most important validation step.
  • No files require special attention beyond awaiting CI confirmation of on-chain key verification.

Important Files Changed

Filename Overview
testnet/0214d264e81e38cc0e75a86e663b0ea33fd2d5772443a889018860660ddaea8494.json New validator metadata JSON for Data Nexus (ID 214). All required fields are present with correct types. Filename matches the secp key. BLS key is 96 hex chars (valid BLS12-381 G1 compressed format). On-chain key verification is deferred to CI validation workflow.

Flowchart

flowchart TD
    A[PR: New Validator JSON File] --> B[Schema Check\nAll 8 required fields present]
    B --> C{Fields Valid?}
    C -->|Yes| D[Filename Check\nMatches secp key]
    D --> E{Filename matches?}
    E -->|Yes| F[Logo URL Check\nhttps://data.nexus/assets/...]
    F --> G[CI: On-chain Key Verification\nsecp & bls vs staking contract]
    G --> H{Keys Match?}
    H -->|Yes| I[Validation Passed]
    H -->|No| J[CI Fails]
    C -->|No| K[Schema Error]
    E -->|No| L[Filename Error]
Loading

Last reviewed commit: 9827af0

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

"bls": "a5d20f3c3c6f22f164ac814c79b68226fb86eabc709fd594d004e0f77d6f21b511df378c3661659930d8f7c551395448",
"website": "https://data.nexus/",
"description": "Powering decentralized applications with data services and validation",
"logo": "https://data.nexus/assets/favicons/android-icon-192x192.png",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Favicon used as validator logo

The logo URL points to an Android favicon (android-icon-192x192.png) rather than a purpose-built validator logo. While 192×192 is a reasonable size, favicons are typically square app icons optimized for browser tabs and home screens — they may not render well in validator listing UIs that expect rectangular or styled logos with transparency or specific aspect ratios. Consider using a dedicated logo asset (e.g. an SVG or a high-res PNG designed for the validator directory context).

Suggested change
"logo": "https://data.nexus/assets/favicons/android-icon-192x192.png",
"logo": "https://data.nexus/assets/logo.png",

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@johnmarcou johnmarcou merged commit 925bb10 into monad-developers:main Feb 17, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants