Skip to content

Adding LI FI testnet validator details#845

Merged
johnmarcou merged 1 commit intomonad-developers:mainfrom
phaselabscrypto:main
Feb 24, 2026
Merged

Adding LI FI testnet validator details#845
johnmarcou merged 1 commit intomonad-developers:mainfrom
phaselabscrypto:main

Conversation

@gabrielhicks
Copy link
Contributor

No description provided.

@greptile-apps
Copy link

greptile-apps bot commented Feb 24, 2026

Greptile Summary

This PR populates the previously empty metadata fields for the LI.FI testnet validator (02c911111...). It adds the website (https://li.fi/), description, logo (favicon SVG), and X/Twitter link. The id, secp, and bls fields remain unchanged.

  • Fills in website, description, logo, and x fields that were previously empty strings
  • The name field is still set to the raw SECP public key rather than a human-readable name like "LI.FI" — this is a minor style issue as most validators use readable names
  • JSON structure and field format are consistent with existing entries in the repository

Confidence Score: 4/5

  • This PR is safe to merge — it only updates metadata fields in a single JSON file with no code logic changes.
  • Simple data-only change that fills in previously empty validator metadata fields. The JSON structure matches the expected schema and all URLs appear valid. Only minor issue is the name field still using the raw key instead of a human-readable name.
  • No files require special attention.

Important Files Changed

Filename Overview
testnet/02c911111b6b7e50d5a7083de7060f7f305fa7697c010c5fa4b304d556d99e91e4.json Populates previously empty validator metadata (website, description, logo, X link) for LI.FI. The name field still uses the raw SECP key instead of a human-readable name.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR: Update LI.FI validator JSON] --> B[testnet/02c911...e4.json]
    B --> C{Fields Updated}
    C --> D["website: https://li.fi/"]
    C --> E["description: All Onchain Liquidity in one API"]
    C --> F["logo: https://li.fi/favicon.svg"]
    C --> G["x: https://x.com/lifiprotocol"]
    B --> H[On Merge to main]
    H --> I[CI: generate_validators_json.py]
    I --> J[Upload to R2 Storage]
Loading

Last reviewed commit: d8b1aca

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@@ -3,8 +3,8 @@
"name": "02c911111b6b7e50d5a7083de7060f7f305fa7697c010c5fa4b304d556d99e91e4",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name field still set to raw SECP key

The name field is still set to the raw SECP public key rather than a human-readable validator name (e.g., "LI.FI"). Most validators in this repo use a readable name — see the example file which shows "name": "Validator name". Consider updating this to something like "LI.FI" for better readability in any validator directory UIs.

Suggested change
"name": "02c911111b6b7e50d5a7083de7060f7f305fa7697c010c5fa4b304d556d99e91e4",
"name": "LI.FI",

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@johnmarcou johnmarcou merged commit f14e837 into monad-developers:main Feb 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants