Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage-search): dissallow empty string on search #69

Merged
merged 2 commits into from
Dec 23, 2024
Merged

fix(storage-search): dissallow empty string on search #69

merged 2 commits into from
Dec 23, 2024

Conversation

gregra81
Copy link
Contributor

No description provided.

royWeisselberg
royWeisselberg approved these changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@royWeisselberg royWeisselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - does this also require the follow up mcode SDK changes?

@gregra81
Copy link
Contributor Author

lgtm - does this also require the follow up mcode SDK changes?

@royWeisselberg no

@gregra81 gregra81 merged commit 8157c3a into master Dec 23, 2024
2 checks passed
@gregra81 gregra81 deleted the dissallow-empty-key-in-search branch December 23, 2024 07:49
@gregra81 gregra81 added the enhancement New feature or request label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@royWeisselberg royWeisselberg royWeisselberg approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregra81 @royWeisselberg