refactor: use types

mondaycom · Jan 26, 2025 · 1a61f57 · 1a61f57
1 parent 1a2ffc3
commit 1a61f57
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/packages/core/src/components/Slider/Slider.tsx b/packages/core/src/components/Slider/Slider.tsx
@@ -11,7 +11,7 @@ import { SliderColor as SliderColorEnum } from "./SliderConstants";
 import cx from "classnames";
 import { withStaticProps } from "../../types";
 import styles from "./Slider.module.scss";
-import { SliderColor, SliderSize } from "./Slider.types";
+import { SliderColor, SliderLabelColor, SliderLabelPosition, SliderSize } from "./Slider.types";
 
 export type SliderProps = {
   /**
@@ -79,11 +79,11 @@ export type SliderProps = {
   /**
    * Position of the `value` when `showValue` is true
    */
-  valueLabelPosition?: "top" | "bottom";
+  valueLabelPosition?: SliderLabelPosition;
   /**
    * Color of the `value` when `showValue` is true
    */
-  valueLabelColor?: "primary" | "secondary";
+  valueLabelColor?: SliderLabelColor;
   /**
    * Size small/medium/large of the component (Slider)
    */

diff --git a/packages/core/src/components/Slider/Slider.types.ts b/packages/core/src/components/Slider/Slider.types.ts
@@ -1,7 +1,13 @@
 import { BASE_SIZES } from "../../constants";
+import { DialogPosition } from "../Dialog";
+import { TypographyColor } from "../Typography";
 
 export type SliderColor = "primary" | "negative" | "positive";
 
+export type SliderLabelColor = Extract<TypographyColor, "primary" | "secondary">;
+
+export type SliderLabelPosition = Extract<DialogPosition, "top" | "bottom">;
+
 export type SliderSize = (typeof BASE_SIZES)[keyof typeof BASE_SIZES];
 
 export type InfixKind = "prefix" | "postfix";
diff --git a/packages/core/src/components/Slider/SliderConstants.ts b/packages/core/src/components/Slider/SliderConstants.ts
@@ -1,6 +1,6 @@
 import { IconType } from "../Icon";
 import { ReactElement } from "react";
-import { SliderSize, SliderColor as SliderColorType } from "./Slider.types";
+import { SliderSize, SliderColor as SliderColorType, SliderLabelPosition, SliderLabelColor } from "./Slider.types";
 
 export const BEM_PREFIX = "monday";
 
@@ -47,8 +47,8 @@ export type SliderContextUI = {
   size: SliderSize;
   shapeTestId: (subElement: string) => string;
   showValue: boolean;
-  valueLabelPosition: "top" | "bottom";
-  valueLabelColor: "primary" | "secondary";
+  valueLabelPosition: SliderLabelPosition;
+  valueLabelColor: SliderLabelColor;
 };
 
 export type SliderContextActions = {