refactor(MenuItem): rename prop

mondaycom · Jan 15, 2025 · ab56960 · ab56960
1 parent 02eba3d
commit ab56960
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 7 deletions.
diff --git a/packages/core/src/components/Menu/MenuItem/MenuItem.tsx b/packages/core/src/components/Menu/MenuItem/MenuItem.tsx
@@ -57,13 +57,11 @@ export interface MenuItemProps extends VibeComponentProps {
   "aria-label"?: AriaAttributes["aria-label"];
   submenuPosition?: SubmenuPosition;
   /**
-   * Enables the observation of content resize for the menu item's submenu.
-   * When set to `true`, a ResizeObserver is attached to the popper content,
-   * automatically triggering repositioning when the size of the submenu's content changes.
+   * When set to `true`, submenu's content and size changes would automatically trigger repositioning.
    *
    * This is useful for when submenu's content may grow or shrink without a re-render being triggered.
    */
-  observeSubMenuContentResize?: boolean;
+  autoAdjustOnSubMenuContentResize?: boolean;
 }
 
 export interface MenuItemTitleComponentProps extends Omit<MenuItemProps, "title"> {

diff --git a/packages/core/src/components/Menu/MenuItem/components/MenuItemSubMenu/MenuItemSubMenu.tsx b/packages/core/src/components/Menu/MenuItem/components/MenuItemSubMenu/MenuItemSubMenu.tsx
@@ -13,7 +13,7 @@ const MenuItemSubMenu = ({
   onClose,
   children,
   submenuPosition,
-  observeSubMenuContentResize
+  autoAdjustOnSubMenuContentResize
 }: MenuItemSubMenuProps) => {
   const childRef = useRef<HTMLDivElement>(null);
   const popperElementRef = useRef<HTMLDivElement>(null);
@@ -38,7 +38,7 @@ const MenuItemSubMenu = ({
     {
       isOpen: open,
       placement: submenuPlacement,
-      observeContentResize: observeSubMenuContentResize
+      observeContentResize: autoAdjustOnSubMenuContentResize
     }
   );
 

diff --git a/...ges/core/src/components/Menu/MenuItem/components/MenuItemSubMenu/MenuItemSubMenu.types.ts b/...ges/core/src/components/Menu/MenuItem/components/MenuItemSubMenu/MenuItemSubMenu.types.ts
@@ -3,7 +3,7 @@ import { CloseMenuOption, MenuChild } from "../../../Menu/MenuConstants";
 import { SubmenuPosition } from "../../MenuItem.types";
 import { MenuItemProps } from "../../MenuItem";
 
-export interface MenuItemSubMenuProps extends Pick<MenuItemProps, "observeSubMenuContentResize"> {
+export interface MenuItemSubMenuProps extends Pick<MenuItemProps, "autoAdjustOnSubMenuContentResize"> {
   /**
    * Reference to the anchor element that the submenu is related to. This is used to position the submenu correctly relative to the parent menu item.
    */