feat(react-select): use react-select version 4.3.1 (#2184)

mondaycom · Jun 26, 2024 · c90b6dd · c90b6dd
1 parent 6bc7748
commit c90b6dd
Show file tree

Hide file tree

Showing 5 changed files with 454 additions and 192 deletions.
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -114,11 +114,11 @@
     "react-inlinesvg": "^3.0.1",
     "react-is": "^16.9.0",
     "react-popper": "^2.3.0",
-    "react-select": "^3.2.0",
+    "react-select": "^4.3.1",
     "react-transition-group": "^4.4.5",
     "react-virtualized-auto-sizer": "^1.0.7",
     "react-window": "^1.8.7",
-    "react-windowed-select": "^2.0.4",
+    "react-windowed-select": "^3.1.2",
     "style-inject": "^0.3.0",
     "vibe-storybook-components": "0.19.0"
   },

diff --git a/packages/core/src/components/Dropdown/Dropdown.tsx b/packages/core/src/components/Dropdown/Dropdown.tsx
@@ -291,7 +291,8 @@ const Dropdown: VibeComponent<DropdownComponentProps, HTMLElement> & {
     );
     const onChange = (option: DropdownOption | DropdownOption[], meta: ActionMeta<DropdownOption>) => {
       if (customOnChange) {
-        customOnChange(option, meta);
+        const newValue = multi ? (option.length > 0 ? option : null) : option;
+        customOnChange(newValue, meta);
       }
 
       switch (meta.action) {

diff --git a/packages/core/src/components/Dropdown/__tests__/Dropdown.test.js b/packages/core/src/components/Dropdown/__tests__/Dropdown.test.js
@@ -150,7 +150,8 @@ describe("Dropdown", () => {
 
       expect(onChange).toBeCalledTimes(2);
       expect(onChange).toHaveBeenLastCalledWith(null, {
-        action: "clear"
+        action: "clear",
+        removedValues: [mockOptions[0]]
       });
       expect(onClear).toBeCalled();
       expect(component.chips.values).toEqual([]);