fix(List): fix error when ListItem is not HTMLElement (#2672)

mondaycom · Dec 22, 2024 · e175d32 · e175d32
1 parent fe1e232
commit e175d32
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/core/src/components/List/List.tsx b/packages/core/src/components/List/List.tsx
@@ -117,7 +117,7 @@ const List: VibeComponent<ListProps> & {
 
     useEffect(() => {
       const selectedItemIndex = childrenRefs.current.findIndex(
-        child => isListItem(child) && child?.getAttribute("aria-selected") === "true"
+        child => child instanceof HTMLElement && isListItem(child) && child?.getAttribute("aria-selected") === "true"
       );
       if (selectedItemIndex !== -1) {
         updateFocusedItem(getListItemIdByIndex(childrenRefs, selectedItemIndex));

diff --git a/packages/core/src/components/List/utils/ListUtils.ts b/packages/core/src/components/List/utils/ListUtils.ts
@@ -37,7 +37,7 @@ export const getListItemComponentType = (listComponent: ListElement): ListItemEl
 };
 
 export const isListItem = (element: HTMLElement) => {
-  return element && element.getAttribute("role") === "option";
+  return element && element instanceof HTMLElement && element.getAttribute("role") === "option";
 };
 
 export const getNextListItemIndex = (currentIndex: number, childrenRefs: MutableRefObject<HTMLElement[]>) => {