Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(build-and-upload): allow to run on both master and other branches #2011

Conversation

YossiSaadi
Copy link
Contributor

…hanges one of the monorepo packages<!--

Please go over the checklist and make sure all conditions are met.

--->

Basic

  • Used plop (npm run plop) to create a new component.
  • PR has description.
  • New component is functional and uses Hooks.
  • Component is written in TypeScript.

Style

  • Styles are added to NewComponent.modules.scss file inside the NewComponent folder.
  • Component uses CSS Modules.
  • Design is compatible with Monday Design System.
  • Styles are defined using monday-ui-style tokens
  • Displays correctly in all the themes

Storybook

  • Stories were added to /src/components/NewComponent/__stories__/NewComponent.mdx file.
  • Stories include all flows of using the component.
  • Stories implemented using vibe-storybook-components components and tokens.

Tests

Accessibility

@YossiSaadi YossiSaadi force-pushed the ci/yossi/CI-align-all-workflows-with-new-reusable-workflows-and-actions-6234512700-test-it-works branch from 0a2c2cb to 1e3fc04 Compare March 12, 2024 15:09
@YossiSaadi YossiSaadi closed this Mar 12, 2024
@YossiSaadi YossiSaadi deleted the ci/yossi/CI-align-all-workflows-with-new-reusable-workflows-and-actions-6234512700-test-it-works branch March 12, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant