test: test infra #2085
test: test infra #2085
Conversation
packages/core/jest.config.js
Outdated
| // slowTestThreshold: 5, | ||
|
|
||
| // A list of paths to snapshot serializer modules Jest should use for snapshot testing | ||
| setupFilesAfterEnv: ["<rootDir>/setupTests.js"], |
There was a problem hiding this comment.
are you sure it should be running for every test? can it run globally in the global setup?
There was a problem hiding this comment.
I see you can also do:
testEnvironment: 'jest-environment-jsdom',
https://testing-library.com/docs/react-testing-library/setup/#jest-27
There was a problem hiding this comment.
instead of having this file
There was a problem hiding this comment.
Looks like setupTest is still needed, but changed to jest-environment-jsdom anyway
packages/core/TESTING_README.md
Outdated
There was a problem hiding this comment.
This file is a bit outdated, I'll open a task to revisit it
| "ts-loader": "^9.3.1", | ||
| "ts-node": "^10.9.2", |
There was a problem hiding this comment.
To use TS config with Jest, (i.e. in node)
There was a problem hiding this comment.
maybe upgrade the version here to be exactly like core, so it would be a shared dep between the two packages, just for convenience
There was a problem hiding this comment.
I was thinking about it, I'll check
| @@ -2,6 +2,8 @@ const path = require("path"); | |||
|
|
|||
| module.exports = { | |||
| process(src, filename) { | |||
| return `module.exports = ${JSON.stringify(path.basename(filename))};`; | |||
| return { | |||
There was a problem hiding this comment.
Due to Jest breaking chnages
packages/core/.eslintrc.js
Outdated
There was a problem hiding this comment.
do we even need the override here?
There was a problem hiding this comment.
same - do we even need the override here?
| @@ -340,7 +340,7 @@ export const TransitionAnimation = { | |||
| ]); | |||
|
|
|||
| setNumActions(numActions + 1); | |||
| }, [steps, setSteps, numActions, setNumActions]); | |||
| }, [numActions, steps, getStepKeyForTransition, STEP_TRANSITIONS, clearSteps]); | |||
| @@ -95,8 +95,7 @@ describe("useDebounceEvent", () => { | |||
| const additionalDelay = 200; | |||
|
|
|||
| beforeEach(() => { | |||
| // @ts-ignore | |||
| jest.useFakeTimers("modern"); | |||
| jest.useFakeTimers(); | |||
There was a problem hiding this comment.
API changed, this is the same
| @@ -39,8 +39,7 @@ | |||
| "lint:fix": "eslint \"./src/**/*.{js,jsx,ts,tsx}\" --fix", | |||
| "prettier:fix": "prettier --write \"{,!(node_modules)/**/}*.{js,jsx,ts,tsx}\"", | |||
| "test": "jest --passWithNoTests", | |||
| "test:update": "yarn test -- -u", | |||
| "test:stories": "testing=storybook TEST_END_FILES=jest-story jest --passWithNoTests", | |||
| "test:update": "yarn test -u", | |||
There was a problem hiding this comment.
Removed the -- due to yarn warning that it's not needed
This reverts commit 4cd0549.
packages/core/.eslintrc.js
Outdated
| @@ -59,7 +59,7 @@ const commonExtends = ["plugin:react/recommended", "plugin:react-hooks/recommend | |||
| module.exports = { | |||
| overrides: [ | |||
| { | |||
| files: ["*.jest.js", "jest.setup.js", "jest.init.js"], | |||
| files: ["jest.init.js"], | |||
There was a problem hiding this comment.
Turns out it's needed for eslint, keeping it for now
https://monday.monday.com/boards/3532714909/pulses/5657864174
https://monday.monday.com/boards/3532714909/pulses/6426652552