feat(Modal): export new Modal component to /next #2641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll Modal and not cut it
talkor
reviewed
Dec 10, 2024
packages/core/src/next.ts
Outdated
| @@ -0,0 +1 @@ | |||
| export * from "./components/next"; | |||
There was a problem hiding this comment.
it was written badly before
now I followed the same pattern that's with the regular export.
the regular export has one index in the root, that's reexports index from hooks/components/etc.
now you have one next in the root, that's reexports next from hooks/components/etc.
There was a problem hiding this comment.
But we're not exporting anything from /next other than components
There was a problem hiding this comment.
Feels a bit like preparation for AC but OK :)
There was a problem hiding this comment.
I removed the preparation for AC, you are right 🙃
talkor
requested changes
Dec 10, 2024
talkor
reviewed
Dec 10, 2024
| @@ -25,12 +25,14 @@ const metaSettings = createStoryMetaSettingsDecorator({ | |||
| }); | |||
|
|
|||
| export default { | |||
| title: "Internal/Components/Modal [New]/Basic modal", | |||
| title: "Components/Modal [New]/Basic modal", | |||
talkor
approved these changes
Dec 10, 2024
…t-for-v3-7360832642-export-all-new-modal-components-and-types-7360977361
YossiSaadi
changed the title
YossiSaadi
deleted the
feat/yossi/add-new-modal-as-next-for-v3-7360832642-export-all-new-modal-components-and-types-7360977361
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/pulses/7360832642
https://monday.monday.com/boards/3532714909/pulses/7360977361
https://monday.monday.com/boards/3532714909/pulses/7989661376
https://monday.monday.com/boards/3532714909/pulses/8010109228