fix(ModalBasicLayout): fix for logic of when to show modal footer shadow #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rivka-ungar
approved these changes
Dec 18, 2024
Comment on lines
+14
to
+16
| setScrollable(scrollHeight > clientHeight); | ||
| setContentScrolled(scrollTop > 0); | ||
| setScrolledToEnd(scrollTop + clientHeight >= scrollHeight); |
There was a problem hiding this comment.
Can these can be optimized to check if the current state is the same as the new one don't update it, as to avoid unnecessary rerenders.
There was a problem hiding this comment.
Discussed in person, React is smart for primitive values (in here only booleans)
YossiSaadi
deleted the
fix/yossi/new-modal-shadow-on-basic-modal-should-show-only-if-8075041798
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://monday.monday.com/boards/3532714909/pulses/8075041798