Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tooltip): add dir prop #2666

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

rivka-ungar
Copy link
Contributor

@rivka-ungar rivka-ungar requested a review from a team as a code owner December 18, 2024 17:25
Copy link
Contributor

@YossiSaadi YossiSaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think what the dev needs is that Typography would pass this on to Tooltip as well (for the ellipsis text).
But I think that's not urgent, let's wait for tomorrow with that one.

@rivka-ungar
Copy link
Contributor Author

I think what the dev needs is that Typography would pass this on to Tooltip as well (for the ellipsis text). But I think that's not urgent, let's wait for tomorrow with that one.

The typography doesn't have a dir prop, you mean adding it to there and then passing it to the tooltip, as supposed to adding it in the tooltip directly? what if someone wants to change it on a tooltip that is not from typography?

@YossiSaadi
Copy link
Contributor

Your code is needed anyway, but I think (if I recall correctly) they've added a dir to Text. So they need that if a Text is rtl, its ellipsis' Tooltip should also be rtl.
Worth asking.

@rivka-ungar rivka-ungar merged commit 5280307 into master Dec 18, 2024
14 checks passed
@rivka-ungar rivka-ungar deleted the tooltip-add-dir-prop-8078910437 branch December 18, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants