add data-testid to tipseen close button #2682
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Merom Cohen <meromco@monday.com>
talkor
requested changes
Dec 26, 2024
| @@ -152,6 +152,7 @@ const Tipseen: VibeComponent<TipseenProps> & { | |||
| [styles.dark]: closeButtonTheme === "dark" || closeButtonTheme === "fixed-dark" | |||
| })} | |||
| onClick={onClose} | |||
| data-testid={getTestId(ComponentDefaultTestId.TIPSEEN_CLOSE_BUTTON)} | |||
There was a problem hiding this comment.
We usually add data-testid for the root elements of components and try to avoid having many data-testids on a lot of elements. We encourage using aria/role attributes as it's the common best practice, in this example you can use the aria-label: [data-testid="tipseen"] [aria-label="Close"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add data-testid to tipseen close button