Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Modal): wrap the overlay and modal inside a container, to allow portaling with layer provider to the container #2703

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: remove commented code
  • Loading branch information
YossiSaadi committed Jan 6, 2025
commit 5eb50f4049a2071e2a2b68a7f303b4248ed95557
3 changes: 0 additions & 3 deletions packages/core/src/components/Modal/Modal/Modal.tsx
Original file line number Diff line number Diff line change
@@ -103,9 +103,6 @@ const Modal = forwardRef(
: modalAnimationCenterPopVariants;

const zIndexStyle = zIndex ? ({ "--monday-modal-z-index": zIndex } as React.CSSProperties) : {};
// useEffect(() => {
// containerRef.current?.style?.setProperty("--monday-modal-z-index", zIndex?.toString() || "");
// }, [zIndex, containerRef]);

return (
<AnimatePresence>
Loading