Skip to content

Commit

Permalink
Fix leftover imports from "lodash" instead of "lodash-es"
Browse files Browse the repository at this point in the history
  • Loading branch information
mbyrne00 committed Dec 15, 2023
1 parent 751cb5e commit e381ed2
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
6 changes: 6 additions & 0 deletions .changeset/quiet-geese-rule.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
"@mondokit/gcp-core": patch
"@mondokit/core": patch
---

Fix leftover imports from "lodash" instead of "lodash-es"
4 changes: 2 additions & 2 deletions packages/core/src/configuration/configuration.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import FileSystem from "fs";
import { merge } from "lodash";
import { merge } from "lodash-es";
import Path from "path";
import { createLogger } from "../logging/logging.js";
import { ENV_VAR_CONFIG_DIR, ENV_VAR_CONFIG_OVERRIDES } from "./variables.js";
import { DataValidator } from "../util/data.js";
import { ENV_VAR_CONFIG_DIR, ENV_VAR_CONFIG_OVERRIDES } from "./variables.js";

export type ConfigValidator<T> = DataValidator<T>;

Expand Down
6 changes: 3 additions & 3 deletions packages/gcp-core/src/configuration/configuration.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import _, { isString } from "lodash";
import { createLogger, ConfigValidator, loadConfiguration as initBaseConfig } from "@mondokit/core";
import { ConfigValidator, createLogger, loadConfiguration as initBaseConfig } from "@mondokit/core";
import { isString, last } from "lodash-es";
import { GcpCoreConfiguration } from "./schema.js";
import { SecretsResolver } from "./secrets/secrets.resolver.js";
import { ENV_VAR_CONFIG_ENV, ENV_VAR_PROJECT } from "./variables.js";
Expand All @@ -24,7 +24,7 @@ export const getProjectId = (optionsProjectId?: string): string | undefined => {

const projectSuffixEnvironment: EnvironmentStrategy = (projectId?: string) => {
if (!projectId) return undefined;
return _.last(projectId.split("-"));
return last(projectId.split("-"));
};

const getEnvironment = (
Expand Down

0 comments on commit e381ed2

Please sign in to comment.