Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧹 Wire up the remainder of aws.iam.role.createdAt #5216

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

tas50
Copy link
Member

@tas50 tas50 commented Feb 14, 2025

It was in the code but not the lr which caused failures

[failed] [].all()
  error: [aws] cannot set 'createdAt' in resource 'aws.iam.group', field not found

It was in the code but not the lr which caused failures

```
[failed] [].all()
  error: [aws] cannot set 'createdAt' in resource 'aws.iam.group', field not found
```

Signed-off-by: Tim Smith <tsmith84@gmail.com>
Copy link
Contributor

Test Results

3 335 tests  ±0   3 331 ✅ ±0   1m 44s ⏱️ -9s
  385 suites ±0       4 💤 ±0 
   29 files   ±0       0 ❌ ±0 

Results for commit 2092d1f. ± Comparison against base commit 097be40.

@chris-rock
Copy link
Member

The resource is already initialized with the value https://github.com/mondoohq/cnquery/blob/main/providers/aws/resources/aws_iam.go#L1428

@chris-rock chris-rock changed the title Wire up the remainder of aws.iam.role.createdAt 🧹 Wire up the remainder of aws.iam.role.createdAt Feb 14, 2025
Copy link
Member

@chris-rock chris-rock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @tas50

@chris-rock chris-rock merged commit 941326f into main Feb 14, 2025
17 checks passed
@chris-rock chris-rock deleted the tas50/fix_aws_role branch February 14, 2025 09:30
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants