Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Let resolved policy tell you if something is a check #1541

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

jaym
Copy link
Contributor

@jaym jaym commented Jan 10, 2025

The output was using an off-handed way of trying to determine if something is a check. The reporting job type has this exact information.

Fixes #1540

@jaym jaym requested a review from slntopp January 10, 2025 12:58
Copy link
Contributor

github-actions bot commented Jan 10, 2025

Test Results

  1 files  ±0   27 suites  ±0   1m 3s ⏱️ +10s
462 tests ±0  461 ✅ ±0  1 💤 ±0  0 ❌ ±0 
463 runs  ±0  462 ✅ ±0  1 💤 ±0  0 ❌ ±0 

Results for commit c1e9a23. ± Comparison against base commit 1e17bc1.

♻️ This comment has been updated with latest results.

The output was using an off-handed way of trying to determine if
something is a check. The reporting job type has this exact information.

Fixes #1540
@jaym jaym merged commit 4dd94f6 into main Jan 10, 2025
15 checks passed
@jaym jaym deleted the jdm/1540 branch January 10, 2025 14:32
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing old resolver breaks output with different formats
2 participants