You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suggest fixing this for now by using 3.12 in the action, in order to unblock frontend as quickly as possible. In the next step, we can think whether we can use action-setup-poetry-python to automatically determine the Python version, like we have already prepared for action-merge-checks.
@felix11h I think we should switch to action-setup-poetry-python as we did for other ones. In this case we will auto-detect the python version for all repositories and with the next Python upgrade, those problems are gone.
@felix11h I think we should switch to action-setup-poetry-python as we did for other ones. In this case we will auto-detect the python version for all repositories and with the next Python upgrade, those problems are gone.
👍 Are comments like that tracked as tickets? I'm afraid this stuff would get lost. Also for tickets one could enlist help from Frontend / Backend.
I think there was some other place also when we wanted to use our setup action with auto detection.
@felix11h I think we should switch to action-setup-poetry-python as we did for other ones. In this case we will auto-detect the python version for all repositories and with the next Python upgrade, those problems are gone.
👍 Are comments like that tracked as tickets? I'm afraid this stuff would get lost. Also for tickets one could enlist help from Frontend / Backend.
I think there was some other place also when we wanted to use our setup action with auto detection.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frontend pipelines are currently not running, see for example https://github.com/moneymeets/moneymeets-dashboard/actions/runs/6686275188/job/18165456270?pr=63. From the first look, this seems because of a Python version mismatch between what is used in the action.yml (
3.11) and configured in pyproject.tom (~3.12).I suggest fixing this for now by using
3.12in the action, in order to unblock frontend as quickly as possible. In the next step, we can think whether we can use action-setup-poetry-python to automatically determine the Python version, like we have already prepared for action-merge-checks.