New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bson-bench): add bson-bench library #1

Merged

durran merged 55 commits into main from NODE-5693/create_bson_bench

Nov 8, 2023

Collaborator

W-A-James commented Oct 17, 2023 •

edited

Loading

Description

This PR adds the bson-bench library described in NODE-5693.

What is changing?

Adds bson-bench library
Changes repo structure to use npm workspaces

Double check the following

Ran npm run check:lint script
Changes are covered by tests
New TODOs have a related JIRA ticket

W-A-James added 2 commits

October 17, 2023 13:33


          add bson-bench package

5e36a74


          further test development and fixes

98c6f1b

W-A-James commented

View reviewed changes

bson-bench/src/common.ts Outdated Show resolved Hide resolved

W-A-James commented

View reviewed changes

bson-bench/src/common.ts Outdated Show resolved Hide resolved

W-A-James commented

View reviewed changes

bson-bench/package.json Outdated Show resolved Hide resolved

W-A-James commented

View reviewed changes

bson-bench/src/base.js Outdated Show resolved Hide resolved

W-A-James commented

View reviewed changes

bson-bench/src/base.js Outdated Show resolved Hide resolved

W-A-James commented

View reviewed changes

bson-bench/src/common.ts Outdated Show resolved Hide resolved

W-A-James commented

View reviewed changes

bson-bench/src/task.ts Outdated Show resolved Hide resolved

W-A-James commented

View reviewed changes

bson-bench/test/unit/common.test.ts Outdated Show resolved Hide resolved

W-A-James commented

View reviewed changes

bson-bench/test/unit/suite.test.ts Outdated Show resolved Hide resolved

W-A-James commented

View reviewed changes

bson-bench/test/unit/task.test.ts Outdated Show resolved Hide resolved

W-A-James commented

View reviewed changes

bson-bench/test/utils.ts Outdated Show resolved Hide resolved

W-A-James commented

View reviewed changes

bson-bench/README.md Outdated Show resolved Hide resolved

W-A-James changed the title ~~add bson-bench package~~ NODE-5693: add bson-bench library

W-A-James added 4 commits

October 18, 2023 11:25


          Address previous comments and fill out tests

91b084b


          move to packages subdir

3991f82


          Update workflows and configure workspace

67fa16f


          update README and add LICENSE

58053a1

W-A-James commented

View reviewed changes

packages/bson-bench/.eslintrc.json Outdated Show resolved Hide resolved

W-A-James commented

View reviewed changes

packages/bson-bench/.mocharc.json Outdated Show resolved Hide resolved

W-A-James commented

View reviewed changes

packages/bson-bench/src/common.ts Outdated Show resolved Hide resolved

W-A-James added 3 commits

October 18, 2023 14:46


          Update workflow

27a3f5a


          add inline documentation

d949f9e


          update package file

fe3887f

W-A-James commented

View reviewed changes

packages/bson-bench/test/utils.ts Outdated Show resolved Hide resolved

W-A-James added 3 commits

October 19, 2023 11:21


          fix inline docs

e3a3d05


          Update tests

42d41c7


          fix utils

393231b

W-A-James commented

View reviewed changes

packages/bson-bench/src/suite.ts Show resolved Hide resolved


          update github workflow

b35f455

W-A-James changed the title ~~NODE-5693: add bson-bench library~~ feat(bson-bench): add bson-bench library


          should run all jobs to completion

c38e92c

durran requested changes

View reviewed changes

Member

durran left a comment

We've actually got more useful failures on the actions now: https://github.com/mongodb-js/dbx-js-tools/actions/runs/6773529163/job/18408594706?pr=1 (tests are actually running)

Collaborator Author

W-A-James commented Nov 6, 2023

Getting one failure I can't yet account for. On Node 20, we fail to install bson-ext from a git commit due to a failure with node-gyp.

The other failures are with installing bson-6.0.0 which is strange because when these tests are run in isolation, they pass.

W-A-James added 2 commits

November 6, 2023 16:01


          reorder versions

448902d


          install bson 6.2 install of 6.0

f8ce3f0

W-A-James commented

View reviewed changes

packages/bson-bench/test/unit/task.test.ts Show resolved Hide resolved

W-A-James requested review from nbbeeken and durran

November 6, 2023 21:20

baileympearson requested changes

View reviewed changes

packages/bson-bench/src/common.ts Outdated Show resolved Hide resolved

W-A-James added 6 commits

November 7, 2023 09:39


          change to discriminated union

2623b29


          always emit declaration files

4764bc2


          update lint workflow

b66489a


          fix lint workflow

4a3e545


          add prepare script

714382a


          skip installing bson-ext via git tag on Node20

24cdfde

nbbeeken previously approved these changes

View reviewed changes


          give metrics different names

ff282dc

W-A-James dismissed nbbeeken’s stale review via

ff282dc

November 7, 2023 20:42

W-A-James added 3 commits

November 7, 2023 15:57


          fix for serialize issues

6cb0861


          fix test

77285f9


          fix benchmark error test

Collaborator

nbbeeken commented Nov 7, 2023

Discussing with @W-A-James we can go ahead an merge this to get a majority of the code landed, and he will open subtasks and corresponding new PRs here if there are further small bug fixes needed to get the bench runner working over in that CI.

nbbeeken requested review from nbbeeken and baileympearson

November 7, 2023 21:50

nbbeeken approved these changes

View reviewed changes

durran approved these changes

View reviewed changes

durran merged commit fc0a6c6 into main

4 checks passed

durran deleted the NODE-5693/create_bson_bench branch

November 8, 2023 15:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels