Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-6357): strip version/branch/tag from test name #19

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

durran
Copy link
Member

@durran durran commented Sep 3, 2024

Description

Strips the version, tag, or branch name from the individual benchmark test names.

What is changing?

  • benchmark_bson@x.x.x strips everything after the @
  • benchmark_bson#tag strips everything after the #
Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-6357

Double check the following

  • Ran npm run check:eslint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran
Copy link
Member Author

durran commented Sep 3, 2024

Note CI failures were introduced in the last commit: https://github.com/mongodb-js/dbx-js-tools/actions/runs/10653808074/job/29529342398

@baileympearson baileympearson self-assigned this Sep 3, 2024
@baileympearson baileympearson added the Primary Review Pull request is being reviewed by primary reviewer label Sep 3, 2024
@baileympearson baileympearson merged commit 043a590 into main Sep 3, 2024
1 of 4 checks passed
@baileympearson baileympearson deleted the NODE-6357 branch September 3, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review Pull request is being reviewed by primary reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants