This repository has been archived by the owner on Jul 9, 2024. It is now read-only.
fix: align ISODate with shell COMPASS-4655 #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcasimir
commented
Jun 25, 2024
| @@ -2,8 +2,8 @@ | |||
| "compilerOptions": { | |||
| /* Basic Options */ | |||
| // "incremental": true, /* Enable incremental compilation */ | |||
| "target": "es5", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */ | |||
| "module": "es2015", /* Specify module code generation: 'none', 'commonjs', 'amd', 'system', 'umd', 'es2015', or 'ESNext'. */ | |||
| "target": "ES2018", /* Specify ECMAScript target version: 'ES3' (default), 'ES5', 'ES2015', 'ES2016', 'ES2017', 'ES2018', 'ES2019' or 'ESNEXT'. */ | |||
There was a problem hiding this comment.
should be safe at this point? helps with regex groups
addaleax
approved these changes
Jun 25, 2024
package-lock.json
Outdated
| "lockfileVersion": 2, | ||
| "requires": true, | ||
| "packages": { | ||
| "": { | ||
| "name": "ejson-shell-parser", | ||
| "version": "2.0.0", | ||
| "version": "2.0.1", |
There was a problem hiding this comment.
We still do releases through npm version patch && git push origin main --tags?
There was a problem hiding this comment.
Not sure. I don't think I've released this in years, how does it relate to this line?
There was a problem hiding this comment.
It just means we usually do the version bumps outside of PRs 🙂 Definitely not a big deal (hence the approval), you can do it whichever way you want
Yeah, this package uses yarn, I think the package lock/yarn lock changes here are being rejected by it 🥴 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we treat
IsoDateasDate.IsoDateworks differently and always construct dates ignoring the current time zone if one is not specified.The code in the PR is copy-pasted from mongosh to make sure we address this type in the same way.