Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-6381): use targeting for x86_64 darwin #26

Merged
merged 3 commits into from
Sep 16, 2024
Merged

Conversation

durran
Copy link
Member

@durran durran commented Sep 13, 2024

Description

Fixes native build for darwin-x86_64

What is changing?

  • Updates the npm build steps in CI fr x86_64 to specifically target that platform.
  • Updates download artifact actions to latest v4, since v2 was removed.
Is there new documentation needed for these changes?

None

What is the motivation for this change?

Broken installs for 1.2.1 on darwin x86_64

Double check the following

  • Ran npm run format:js && npm run format:rs script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@durran durran changed the title fix: use targeting for x64 darwin fix: use targeting for x86_64 darwin Sep 13, 2024
@durran durran marked this pull request as ready for review September 13, 2024 13:14
@durran durran changed the title fix: use targeting for x86_64 darwin fix(NODE-6381): use targeting for x86_64 darwin Sep 16, 2024
@durran durran merged commit f95c9f6 into main Sep 16, 2024
29 checks passed
@durran durran deleted the fix-darwin-x64 branch September 16, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant