-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(NODE-6578): add misc tooling to ZSTD repo #36
Conversation
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
1170891
to
5284027
Compare
analyze: | ||
name: Analyze (${{ matrix.language }}) | ||
runs-on: "ubuntu-latest" | ||
timeout-minutes: 360 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodeQL only takes about 2 minutes, is there a reason we put a timeout here and chose 360?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not really, no.
This is directly copied from mongodb-client-encryption, which was auto-generated by Github for us. I could adjust it if you want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to change it if it matches the existing code for mongodb-client-encryption!
@@ -2,13 +2,19 @@ | |||
ARG PLATFORM=arm64 | |||
ARG NODE_VERSION=16.20.1 | |||
|
|||
FROM ${PLATFORM}/node:${NODE_VERSION}-alpine AS node | |||
FROM ${PLATFORM}/node:${NODE_VERSION}-alpine AS build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the motivation behind this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The last line in the dockerfile:
COPY --from=build /zstd/prebuilds/ /
Requires that tag used in --from is the same as the tag here. I chose to change this to build to match Dockerfile.glibc instead of adjusting the tag below to --from=node
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning: 0:0 warning File ignored by default. Use a negated ignore pattern (like "--ignore-pattern '!<relative/path/to/filename>'") to override
Why doesn't this happen on our other repos? I'm seeing github post a warning on the .release-please-manifest.json file
We don't lint json files in our other repos. I set this up when I set up eslint and mocha - you pointed out they were malformed and we decided to lint them. |
Description
What is changing?
This PR contains a smattering of tooling we'll need for the SSDLC release flow (coming in the next PR):
build
action has been added, that builds the bindings and uploads the to GHA artifact storage (for use in the release action later, coming in a follow-up PR)Is there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run format:js && npm run format:rs
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript