Skip to content

DOCSP-32117 default curly braces in query #588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 10, 2024

Conversation

ltran-mdb2
Copy link
Collaborator

@ltran-mdb2 ltran-mdb2 commented Jan 9, 2024

DESCRIPTION

Compass automatically adds curly braces to filter input text

STAGING

https://preview-mongodbltranmdb2.gatsbyjs.io/compass/DOCSP-32117/query/filter/

JIRA

https://jira.mongodb.org/browse/DOCSP-32117

BUILD LOG

https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=659d833bdcc0144a518df554

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Is this free of spelling errors?
  • Is this free of grammatical errors?
  • Is this free of staging / rendering issues?
  • Are all the links working?

External Review Requirements

What's expected of an external reviewer?

Sorry, something went wrong.

Copy link
Collaborator

@ajhuh-mdb ajhuh-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % one missing word!

#. In the :guilabel:`Filter` field, enter a filter document. You can use
all of the MongoDB :manual:`query operators
#. In the :guilabel:`Filter` field, enter a filter document between the
curly braces. You can use all the MongoDB :manual:`query operators
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] looks like the word "of" got left out from the original copy

Suggested change
curly braces. You can use all the MongoDB :manual:`query operators
curly braces. You can use all of the MongoDB :manual:`query operators

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took "of" out for minimalism (on vale's suggestion to pass the check)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah gotcha!

@sarah-olson-mongodb sarah-olson-mongodb merged commit 295af3f into mongodb:master Jan 10, 2024
@docs-builder-bot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants