-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP 27810 updating schema validation behavior #589
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM % a couple small fixes!
source/validation.txt
Outdated
|compass-short| updates in real-time to display a document from your | ||
collection that passes the validation and a document that fails. | ||
expressions using :manual:`query operators </reference/operator/query>`. | ||
When you hit the Update button, Compass updates to display a document |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nit] For UI instructions, we want to be more explicit in what the users have to do — it might be confusing for international audiences to read about "hitting" a button.
Also for the update button, we want to add the :guilabel:
directive!
When you hit the Update button, Compass updates to display a document | |
After you click the :guilabel:`Update` button, Compass updates to display a document |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done! Thanks for your feedback!
✨ Staging URL: https://preview-mongodbmongodb.gatsbyjs.io/compass/master/ 🪵 Logs |
DESCRIPTION
schema validation no longer auto updates in Compass
STAGING
https://docs-mongodbcom-staging.corp.mongodb.com/compass/docsworker-xlarge/DOCSP-27810/validation/#validation-rules
JIRA
https://jira.mongodb.org/browse/DOCSP-27810
BUILD LOG
https://workerpool-boxgs.mongodbstitch.com/pages/job.html?collName=queue&jobId=65a6f1f2dcc0144a51094dfb
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?