DOCSP-46667-Repetitive-file-path-query-natural-language #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-compass ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ajhuh-mdb
approved these changes
Jan 22, 2025
config/redirects
Outdated
| @@ -16,3 +16,6 @@ raw: docs/compass/ -> ${base}/current/ | |||
|
|
|||
| # DOCSP-44185 - Cmd line options redirect | |||
| [*]: docs/compass/${version}/command-line-options/ -> ${base}/current/settings/command-line-options/ | |||
|
|
|||
| # Repetitive file paths | |||
| [*]: docs/compass/${version}/query-with-natural-language/query-with-natural-language -> ${base}/${version}/query-with-natural-language | |||
There was a problem hiding this comment.
[non-blocker] just a heads up we want to make sure the file ends with a newline!
There was a problem hiding this comment.
it's not showing it in github 😿 but i have added one
| @@ -15,6 +15,9 @@ jobs: | |||
| - name: checkout | |||
| uses: actions/checkout@master | |||
|
|
|||
| - name: Install docutils | |||
There was a problem hiding this comment.
[non-blocker] just checking this belongs in this PR?
There was a problem hiding this comment.
yup! it's to stop the vale checks from automatically failing
There was a problem hiding this comment.
perf thanks for the confirm!
mayaraman19
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
updates /query-with-natural-language/query-with-natural-language -> /query-with-natural-language, adds a redirect for this path, and adds dependency for vale checks
STAGING
https://deploy-preview-711--docs-compass.netlify.app/query-with-natural-language/
Mut output:
JIRA
https://jira.mongodb.org/browse/DOCSP-46667
BUILD LOG
Self-Review Checklist
External Review Requirements
What's expected of an external reviewer?