GODRIVER-3704 Fix search index failure on empty "Options". #2247
+76
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
review-priority-normal
Contributor
🧪 Performance ResultsCommit SHA: 1373cf2The following benchmark tests for version 692dc1709bc46e00075de220 had statistically significant changes (i.e., |z-score| > 1.96):
For a comprehensive view of all microbenchmark results for this PR's commit, please check out the Evergreen perf task for this patch. |
Contributor
API Change ReportNo changes found! |
qingyang-hu
force-pushed
the
godriver3704
branch
5 times, most recently
from
1c96085 to
ee65456
Compare
qingyang-hu
force-pushed
the
godriver3704
branch
from
ee65456 to
86957b1
Compare
qingyang-hu
commented
Nov 26, 2025
Comment on lines
-29
to
-33
| assume-test-secrets-ec2-role: | ||
| - command: ec2.assume_role | ||
| params: | ||
| role_arn: ${aws_test_secrets_role} | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Duplicate of L175
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where search index creation failed when SearchIndexModel.Options is nil. The fix ensures that the document element is always started before checking for optional fields.
Key changes:
- Moved
AppendDocumentElementStartcall outside theOptions != nilcheck to ensure proper BSON document construction - Added integration test to verify search index creation with empty options
- Standardized environment variable naming from
TEST_INDEX_URItoSEARCH_INDEX_URI
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
mongo/search_index_view.go |
Fixed bug by moving AppendDocumentElementStart before the Options != nil check, ensuring proper BSON document structure regardless of Options value |
internal/integration/search_index_test.go |
Added new integration test to verify search index creation with empty Options |
internal/integration/search_index_prose_test.go |
Updated environment variable name from TEST_INDEX_URI to SEARCH_INDEX_URI for consistency |
Taskfile.yml |
Updated test runner to execute both TestSearchIndex and TestSearchIndexProse tests |
.evergreen/config.yml |
Updated environment variable naming to SEARCH_INDEX_URI and removed duplicate assume-test-secrets-ec2-role function definition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
qingyang-hu
force-pushed
the
godriver3704
branch
from
58bc4c2 to
1373cf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-3704
Summary
Background & Motivation