Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Atlas client transport customization #1029

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Support Atlas client transport customization #1029

merged 3 commits into from
Jul 13, 2023

Conversation

josvazg
Copy link
Collaborator

@josvazg josvazg commented Jul 7, 2023

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 7, 2023 •
edited
Loading

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/4adab9c8d676b2dc5c5b6e18e396742531954bd9

@josvazg josvazg force-pushed the custom-atlas-client branch 2 times, most recently from bb8c78f to dfe4b1e Compare July 10, 2023 07:39
helderjs
helderjs requested changes Jul 11, 2023
View reviewed changes
pkg/controller/atlas/client.go Outdated Show resolved Hide resolved
pkg/controller/atlas/client_test.go Outdated Show resolved Hide resolved
pkg/controller/atlas/logger.go Outdated Show resolved Hide resolved
@josvazg josvazg changed the title Support Atlas client customization & logging Support Atlas client transport customization Jul 12, 2023
josvazg
josvazg commented Jul 12, 2023
View reviewed changes
Makefile Show resolved Hide resolved
@josvazg
Support Atlas client customization & logging
da0ee8f 
Signed-off-by: Jose Vazquez <jose.vazquez@mongodb.com>
@josvazg josvazg requested a review from helderjs July 12, 2023 07:42
igor-karpukhin
igor-karpukhin approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@igor-karpukhin igor-karpukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

josvazg and others added 2 commits July 12, 2023 12:55
@josvazg @gssbzn
Update pkg/controller/atlas/client_test.go
7e0e111 
Co-authored-by: Gustavo Bazan <gssbzn@gmail.com>
@josvazg @gssbzn
Update pkg/controller/atlas/client_test.go
4adab9c 
Co-authored-by: Gustavo Bazan <gssbzn@gmail.com>
helderjs
helderjs approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@helderjs helderjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josvazg josvazg merged commit 0d639a3 into main Jul 13, 2023
38 checks passed
@josvazg josvazg deleted the custom-atlas-client branch July 13, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igor-karpukhin igor-karpukhin igor-karpukhin approved these changes

@helderjs helderjs helderjs approved these changes

@gssbzn gssbzn gssbzn approved these changes

@roothorp roothorp Awaiting requested review from roothorp

@cveticm cveticm Awaiting requested review from cveticm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josvazg @helderjs @gssbzn @igor-karpukhin