Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-188104: Deployment Resource Tagging #1041

Merged
merged 68 commits into from
Aug 24, 2023
Merged

CLOUDP-188104: Deployment Resource Tagging #1041

merged 68 commits into from
Aug 24, 2023

Conversation

cveticm
Copy link
Collaborator

@cveticm cveticm commented Jul 18, 2023

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023 •
edited
Loading

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/442041042a496134ba9e6a7d0da23b5f4e2b7b9d

@cveticm cveticm changed the title Cloudp 188104/deployment resource tagging CLOUDP-188104/deployment resource tagging Jul 18, 2023
@cveticm cveticm closed this Jul 18, 2023
@cveticm cveticm reopened this Jul 24, 2023
@cveticm cveticm marked this pull request as draft July 24, 2023 15:03
@cveticm cveticm changed the title CLOUDP-188104/deployment resource tagging CLOUDP-188104:deployment resource tagging Jul 24, 2023
@cveticm cveticm changed the title CLOUDP-188104:deployment resource tagging CLOUDP-188104: Deployment Resource Tagging Jul 24, 2023
josvazg
josvazg reviewed Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused, I was assuming that tags order did not matter. Can you confirm this point?

@josvazg
Copy link
Collaborator

josvazg commented Aug 4, 2023

LGTM, except I would like to confirm whether or not that pathological case of trying to reorder tags that never get reordered cannot happen.

josvazg
josvazg approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

roothorp
roothorp approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@roothorp roothorp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one tiny comment to remove (?)

pkg/controller/atlasdeployment/atlasdeployment_controller_test.go Outdated Show resolved Hide resolved
igor-karpukhin
igor-karpukhin approved these changes Aug 14, 2023
View reviewed changes
Copy link
Collaborator

@igor-karpukhin igor-karpukhin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general 👍

pkg/controller/atlasdeployment/serverless_deployment.go Show resolved Hide resolved
pkg/controller/atlasdeployment/serverless_deployment.go Outdated Show resolved Hide resolved
@igor-karpukhin igor-karpukhin added the hold Do not merge for now label Aug 18, 2023
@igor-karpukhin igor-karpukhin removed the hold Do not merge for now label Aug 24, 2023
@igor-karpukhin igor-karpukhin merged commit df7db35 into main Aug 24, 2023
40 checks passed
@igor-karpukhin igor-karpukhin deleted the CLOUDP-188104/deployment-resource-tagging branch August 24, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josvazg josvazg josvazg approved these changes

@igor-karpukhin igor-karpukhin igor-karpukhin approved these changes

@roothorp roothorp roothorp approved these changes

@helderjs helderjs Awaiting requested review from helderjs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cveticm @josvazg @helderjs @igor-karpukhin @roothorp