Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-195050: Atlas Federated Authentication configuration #1124

Merged
merged 3 commits into from
Oct 6, 2023
Merged

CLOUDP-195050: Atlas Federated Authentication configuration #1124

merged 3 commits into from
Oct 6, 2023

Conversation

igor-karpukhin
Copy link
Collaborator

@igor-karpukhin igor-karpukhin commented Sep 7, 2023 •
edited
Loading

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes.md if your changes should be included in the release notes for the next release.

@roothorp roothorp force-pushed the CLOUDP-195050/atlas-federated-auth branch from 6b85d4a to 6d31ace Compare September 8, 2023 13:35
@igor-karpukhin igor-karpukhin force-pushed the CLOUDP-195050/atlas-federated-auth branch 2 times, most recently from c5957fe to 795b2bd Compare September 21, 2023 14:00
@igor-karpukhin igor-karpukhin marked this pull request as ready for review September 22, 2023 18:29
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023 •
edited
Loading

https://app.codecov.io/github/mongodb/mongodb-atlas-kubernetes/commit/a8ba9800e128b4e44e393ccebdead5b99ce00efd

helderjs
helderjs requested changes Sep 26, 2023
View reviewed changes
pkg/api/v1/atlasfederatedauth_types_test.go Outdated Show resolved Hide resolved
pkg/controller/atlasfederatedauth/atlasfederatedauth_controller.go Outdated Show resolved Hide resolved
pkg/api/v1/atlasfederatedauth_types.go Outdated Show resolved Hide resolved
pkg/controller/atlasfederatedauth/atlasfederatedauth.go Outdated Show resolved Hide resolved
test/int/federatedauth_test.go Outdated Show resolved Hide resolved
@josvazg josvazg mentioned this pull request Sep 27, 2023
Merged
3 tasks
helderjs
helderjs approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@helderjs helderjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

josvazg
josvazg approved these changes Sep 27, 2023
View reviewed changes
Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@helderjs helderjs force-pushed the CLOUDP-195050/atlas-federated-auth branch 3 times, most recently from 3cddc6b to c118f21 Compare October 4, 2023 16:07
@helderjs helderjs force-pushed the CLOUDP-195050/atlas-federated-auth branch from d0edacb to 18706ed Compare October 6, 2023 09:14
@josvazg
Copy link
Collaborator

josvazg commented Oct 6, 2023

LGTM

@helderjs helderjs merged commit 3769e68 into main Oct 6, 2023
41 checks passed
@helderjs helderjs deleted the CLOUDP-195050/atlas-federated-auth branch October 6, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roothorp roothorp roothorp left review comments

@helderjs helderjs helderjs approved these changes

@josvazg josvazg josvazg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igor-karpukhin @josvazg @helderjs @roothorp