Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-231603: Fix updating dependabot licenses #1409

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

josvazg
Copy link
Collaborator

@josvazg josvazg commented Feb 28, 2024

✅ Managed to fix dependabot PR #1408 (launched manually)

All Submissions:

  • Have you signed our CLA?

@josvazg
Copy link
Collaborator Author

josvazg commented Feb 28, 2024

I manually forced a dependabot re-check following instruction from dependabot/dependabot-core#2980

Go to https://github.com/mongodb/mongodb-atlas-kubernetes/network/updates
Open Recent update jobs for go mod and click Check for updates

git config user.email "akobot@ako-team-fake.mongodb.com"
git config user.name "AKOBot"
git add .
git commit -m "Fix licenses after dependabot changes"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think including dependabot skip in the commit message means you avoid the error you're getting.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@josvazg josvazg force-pushed the CLOUDP-231603/test-fix-dependabot branch 2 times, most recently from 16fc00c to e5647dc Compare February 29, 2024 08:44
Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>
@josvazg josvazg force-pushed the CLOUDP-231603/test-fix-dependabot branch from e5647dc to 29eb518 Compare February 29, 2024 11:30
run: |
if [[ $(git diff --stat) != '' ]]; then
echo 'Committing changes'
git config user.email "akobot@ako-team-fake.mongodb.com"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this parameter mandatory?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it seems git complains otherwise. Also it is best we know it was the bot that did the PR.

@josvazg josvazg merged commit d6fc605 into main Feb 29, 2024
8 checks passed
@josvazg josvazg deleted the CLOUDP-231603/test-fix-dependabot branch February 29, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants