CLOUDP-238743: Use mongodb/signatures #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josvazg
requested review from
helderjs,
s-urbaniak,
igor-karpukhin and
roothorp
helderjs
approved these changes
Mar 21, 2024
josvazg
force-pushed
the
CLOUDP-238743/use-mongodb-sign-registry
branch
from
a4c0af9
to
64be7f2
Compare
s-urbaniak
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before merging this I would need to update the secrets
DOCKER_USERNAMEandDOCKER_PASSWORD.New username is svcdockerhubatlaskubernetes202
Note those creds will be lost once we do the change. I have tested we can push to all 3 registries in use:
Any other testing required needs to happen before we make the credentials change.
All Submissions: