CLOUDP-238747: Fix automatic release on PR merge #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josvazg
force-pushed
the
CLOUDP-238747/fix-auto-release
branch
3 times, most recently
from
fadf79b
to
e3bf948
Compare
Signed-off-by: jose.vazquez <jose.vazquez@mongodb.com>
josvazg
force-pushed
the
CLOUDP-238747/fix-auto-release
branch
from
e3bf948
to
45003a4
Compare
josvazg
requested review from
igor-karpukhin,
helderjs,
roothorp and
s-urbaniak
josvazg
changed the title
helderjs
reviewed
Mar 21, 2024
| RELEASE_HELM: ${{ github.event.inputs.release_helm || 'true' }} | ||
| CERTIFY: ${{ github.event.inputs.certify || 'true' }} | ||
| RELEASE_TO_GITHUB: ${{ github.event.inputs.release_to_github || 'true' }} | ||
| BRANCH: ${{ github.event.inputs.branch || 'main' }} | ||
| BRANCH: ${{ github.event.inputs.branch || github.head_ref || github.ref_name || 'main' }} |
There was a problem hiding this comment.
I'm wondering if only ${{ github.event.inputs.branch || github.head_ref }} would be enough given the events that triggers this workflow
There was a problem hiding this comment.
It might be so. I prefer to have extra fallback for now.
helderjs
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions: