Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-277319: Added helm automation job #2 #1870

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

igor-karpukhin
Copy link
Collaborator

All Submissions:

  • Have you signed our CLA?
  • Put closes #XXXX in your comment to auto-close the issue that your PR fixes (if there is one).
  • Update docs/release-notes/release-notes-template.md if your changes should be included in the release notes for the next release.

@@ -11,7 +11,7 @@ DOCKER_SBOM_PLUGIN_VERSION=0.6.1
# To re-generate a bundle for another specific version without changing the standard setup, you can:
# - use the VERSION as arg of the bundle target (e.g make bundle VERSION=0.0.2)
# - use environment variables to overwrite this value (e.g export VERSION=0.0.2)
VERSION ?= $(shell git describe --tags --dirty --broken | cut -c 2-)
VERSION ?= $(shell git describe --always --tags --dirty --broken | cut -c 2-)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does --always change in terms of VERSION generation?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sure that git always returns exit code 0. Without it, if will fail with "Nothing to describe" if there are no tags

Copy link
Collaborator

@josvazg josvazg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this finally work? I can't see a working run here:
https://github.com/mongodb/mongodb-atlas-kubernetes/actions/workflows/update-helm.yaml

@josvazg
Copy link
Collaborator

josvazg commented Oct 16, 2024

FYI, I created CLOUDP-278910 CI GH App token action consistent for a discussion

@igor-karpukhin
Copy link
Collaborator Author

@josvazg unfortunately it doesn't. But as you can see, I found a way to generate token inside the Github Action, instead of encoding the key with base64 and then calling a makefile

@igor-karpukhin
Copy link
Collaborator Author

igor-karpukhin commented Oct 16, 2024

Reopened as the workflow has been proved to be correct. The issue is with the credentials

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants