fix(NODE-7308): replace process.nextTick with queueMicrotask #4817
+35
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelSafronov
force-pushed
the
NODE-7308
branch
from
5b9abd1 to
52b36e3
Compare
PavelSafronov
force-pushed
the
NODE-7308
branch
from
52b36e3 to
ae2e037
Compare
addaleax
previously approved these changes
Dec 3, 2025
tadjik1
reviewed
Dec 8, 2025
| // This is a guarantee in node, unless you are performing a transaction (which is not being done in this test) | ||
| expect(new Set(events.map(ev => ev.command.lsid.id.toString('hex')))).to.have.lengthOf(1); | ||
| const uniqueSessionIds = new Set(events.map(ev => ev.command.lsid.id.toString('hex'))); | ||
| expect(uniqueSessionIds).to.have.length.lessThanOrEqual(2); |
Member
There was a problem hiding this comment.
Can you please elaborate on this change?
Maybe some summary from the slack thread would be good for potential future investigations, wdyt?
Contributor
Author
There was a problem hiding this comment.
Absolutely, adding information about the timing, as well as an example bulkWrite that would have broken the old version of this test.
tadjik1
added
the
Primary Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Replace process.nextTick() with .queueMicrotask()
What is the motivation for this change?
This helps us reduce our runtime dependencies, as part of https://jira.mongodb.org/browse/NODE-6601
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript