use older 2.0.4 version of whatwg-fetch in browser core package#302
Open
neonguru wants to merge 1 commit intomongodb:masterfrom
Open
use older 2.0.4 version of whatwg-fetch in browser core package#302neonguru wants to merge 1 commit intomongodb:masterfrom
neonguru wants to merge 1 commit intomongodb:masterfrom
Conversation
Contributor
|
Haven't had the time to look at this too closely yet, but @neonguru do you have any idea what changed in |
Contributor
|
I'm hesitant to downgrade a dependency without understanding what changed. |
Author
|
There is an issue in their repo already regarding this: |
Author
|
But it's going on a year that they've known about it... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves issue #186
The whatwg-fetch module is responsible for the window is not defined error.
By using the previous version of that module, the error does not occur and everything works as required.
Tested in my SSR application and it is working as intended.